Remove Astro-flavored Markdown from @astrojs/markdown-remark
#5785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4fcbc0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
delucis
changed the title
delucis
changed the title
@astrojs/markdown-remark
natemoo-re
reviewed
Jan 6, 2023
|
Got one ready to push but didn’t want to disturb the test run 😅 |
|
Heading out for the day but if it’s helpful to merge this at any point this afternoon, please do! |
natemoo-re
approved these changes
Jan 6, 2023
matthewp
approved these changes
Jan 6, 2023
delucis
changed the title
@astrojs/markdown-remark@astrojs/markdown-remark
Merged
delucis
added a commit
that referenced
this pull request
Jan 9, 2023
Follow up to #5785. Missed one dependency that is no longer used and can be removed.
This was referenced Jan 9, 2023
delucis
added a commit
that referenced
this pull request
Jan 9, 2023
* [markdown-remark] Remove unused dependency Follow up to #5785. Missed one dependency that is no longer used and can be removed. * [markdown-remark] Remove unused dependency * Lockfile fix * Update lockfile [again]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cleans up
@astrojs/markdown-remarkremoving syntax tooling that is no longer needed now that we are not supporting Astro-flavored Markdown.astroFlavoredMdoption from therenderMarkdownmethodTesting
I’ve removed AFMD-specific tests.
Docs
We’re already documenting AFMD’s demise, so no additional docs associated with this PR.